Latest libxmtp - permissions and description field updates #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
force-pushed
the
cv/latest-libxmtp-permissions-description-updates
branch
from
a062588 to
0bb8a1f
Compare
…ttps://github.com/xmtp/xmtp-react-native into cv/latest-libxmtp-permissions-description-updates
cameronvoell
force-pushed
the
cv/latest-libxmtp-permissions-description-updates
branch
from
3c6b741 to
f4f45c4
Compare
alexrisch
reviewed
Jul 2, 2024
example/ios/xmtpreactnativesdkexample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
alexrisch
approved these changes
Jul 2, 2024
nplasterer
approved these changes
Jul 2, 2024
| return mapOf( | ||
| "clientAddress" to client.address, | ||
| "id" to group.id.toHex(), | ||
| "createdAt" to group.createdAt.time, | ||
| "peerInboxIds" to group.peerInboxIds(), | ||
| "version" to "GROUP", | ||
| "topic" to group.topic, | ||
| "permissionLevel" to permissionString, | ||
| "permissionPolicySet" to permissionPolicySet, |
There was a problem hiding this comment.
I'm not sure this is still needed here since you no longer parse it on the group object?
There was a problem hiding this comment.
good call, this isnt being used anymore, removed here 1e5fcd5
cameronvoell
deleted the
cv/latest-libxmtp-permissions-description-updates
branch
|
🎉 This PR is included in version 1.34.0-beta.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Android native module
iOS native module
RN library
See new test "can update group permissions" at the bottom:
