Add TLS certificate configuration and public IP #10
+96
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
force-pushed
the
12-03-assign_public_ip
branch
2 times, most recently
from
43bc9ea
to
f1638f8
Compare
neekolas
changed the title
neekolas
force-pushed
the
12-03-assign_public_ip
branch
from
f1638f8
to
4b4275d
Compare
neekolas
force-pushed
the
12-03-assign_public_ip
branch
from
4b4275d
to
f6aaae4
Compare
richardhuaaa
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
mls_validation_serviceNotes
The domain needs to be pre-registered through the AWS console. I haven't been able to make it work through automation. Once the domain is registered and the status has moved past pending Terraform will take control of the domain and register the name servers appropriately.