Add postgres config #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
force-pushed
the
11-26-add_postgres_config
branch
from
e49f476
to
c44a28a
Compare
neekolas
commented
Nov 27, 2024
| @@ -0,0 +1,88 @@ | |||
| locals { | |||
| db_engine_version = "16" | |||
There was a problem hiding this comment.
Rather than make all these configurable as variables, I think hardcoded locals make the most sense. This is meant to be an example and custom DB config is out of scope.
There was a problem hiding this comment.
on a side note. Is there any minimal version of PG we require? I don't think that we use any special PG syntax.
There was a problem hiding this comment.
I haven't tested with very old versions, but I would expect everything to work.
Maybe we just say 13 is minimum, which is the lowest we've tested on
neekolas
force-pushed
the
11-26-add_postgres_config
branch
2 times, most recently
from
0a160cb
to
85071f0
Compare
neekolas
force-pushed
the
11-26-add_postgres_config
branch
from
85071f0
to
08f94f1
Compare
richardhuaaa
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds RDS Aurora PostgreSQL database configuration and connects it to xmtpd services.
What changed?