Initial publish implementation #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @richardhuaaa and the rest of your teammates on |
richardhuaaa
force-pushed
the
08-07-create_first_db_query
branch
from
3a61ad3
to
13280f6
Compare
richardhuaaa
force-pushed
the
08-02-initial_publish_implementation
branch
from
546abee
to
a016f66
Compare
richardhuaaa
force-pushed
the
08-07-create_first_db_query
branch
from
13280f6
to
9844de2
Compare
richardhuaaa
force-pushed
the
08-02-initial_publish_implementation
branch
from
a016f66
to
3a6b69b
Compare
neekolas
reviewed
Aug 9, 2024
| @@ -5,5 +5,14 @@ | |||
| "pgFormatter.tabs": true, | |||
| "[sql]": { | |||
| "editor.defaultFormatter": "bradymholt.pgformatter" | |||
| }, | |||
| // Instructions from https://github.com/segmentio/golines | |||
neekolas
approved these changes
Aug 9, 2024
Merge activity
|
richardhuaaa
changed the base branch from
08-07-create_first_db_query
to
graphite-base/101
richardhuaaa
force-pushed
the
08-02-initial_publish_implementation
branch
from
3a6b69b
to
21cfd44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of the publish endpoint and unit test setup. Simply writes to the staged envelopes table and does nothing else.
Also fixed some issues around DB and connection lifetimes - the migration step now closes the connection it uses (but not the whole DB instance).