Use helper method instead of eval

xp-framework · Mar 23, 2024 · 1c26ddb · 1c26ddb
1 parent df9e43f
commit 1c26ddb
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/test/php/lang/unittest/CommandLineTest.class.php b/src/test/php/lang/unittest/CommandLineTest.class.php
@@ -6,6 +6,12 @@
 
 class CommandLineTest {
 
+  /** @return iterable */
+  private function implementations() {
+    yield [CommandLine::$UNIX];
+    yield [CommandLine::$WINDOWS];
+  }
+
   #[Test]
   public function forWindows() {
     Assert::equals(CommandLine::$WINDOWS, CommandLine::forName('Windows'));
@@ -266,12 +272,12 @@ public function evalCommandLineWindowsTripleClosedBySingle() {
     );
   }
 
-  #[Test, Values(eval: 'CommandLine::values()')]
+  #[Test, Values(from: 'implementations')]
   public function resolve_non_existant($impl) {
     Assert::false($impl->resolve('@non-existant@')->valid());
   }
 
-  #[Test, Values(eval: 'CommandLine::values()')]
+  #[Test, Values(from: 'implementations')]
   public function resolve_empty($impl) {
     Assert::false($impl->resolve('')->valid());
   }