MFH TODO -> https://wiki.php.net/rfc/make-reflection-setaccessible-no-op

xp-framework · Aug 25, 2024 · e082eff · e082eff
2 parents c70b2f7 + fab6891
commit e082eff
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/main/php/lang/reflection/Property.class.php b/src/main/php/lang/reflection/Property.class.php
@@ -74,6 +74,9 @@ public function modifiers($hook= null) {
    */
   public function get(?object $instance) {
     try {
+
+      // TODO: Remove superfluous call to setAccessible() if on PHP8.1+
+      // see https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
       $this->reflect->setAccessible(true);
       return $this->reflect->getValue($instance);
     } catch (ReflectionException $e) {
@@ -94,6 +97,9 @@ public function get(?object $instance) {
    */
   public function set(?object $instance, $value) {
     try {
+
+      // TODO: Remove superfluous call to setAccessible() if on PHP8.1+
+      // see https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
       $this->reflect->setAccessible(true);
       $this->reflect->setValue($instance, $value);
       return $value;