Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the release workflow #176

Merged
merged 1 commit into from
Nov 25, 2024
Merged

ci: fix the release workflow #176

merged 1 commit into from
Nov 25, 2024

Conversation

malor
Copy link
Member

@malor malor commented Nov 25, 2024

  1. The path is incorrect because we meant to capture the value of
    $PWD before and not after running popd

  2. The HOST value is different on Mac OS (the OS part is "macos"
    instead of the expected "darwin"). There appears to be no way to
    get this from some structured data in stable rustc, so we resort
    to grep that works on all platforms

@malor malor requested a review from ikalnytskyi November 25, 2024 07:44
1) The path is incorrect because we meant to capture the value of
   `$PWD` _before_ and not after running `popd`

2) The `HOST` value is different on Mac OS (the OS part is "macos"
   instead of the expected "darwin"). There appears to be no way to
   get this from some structured data in stable rustc, so we resort
   to grep that works on all platforms
@malor malor merged commit 6ec517a into master Nov 25, 2024
8 checks passed
@malor malor deleted the ci2 branch November 25, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants