Add missing libssl-dev library and remove explicit addition of npm #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
approved these changes
Mar 22, 2024
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install Node.js per recommended setup. | ||
| RUN mkdir -p /etc/apt/keyrings \ | ||
| && curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \ | ||
| && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_VERSION}.x nodistro main" >> /etc/apt/sources.list.d/nodesource.list \ | ||
| && apt-get update \ | ||
| && apt-get -y --no-install-recommends install nodejs npm \ |
There was a problem hiding this comment.
praise: Thanks for fixing this. I noticed this issue as well but didn't get to fixing it upstream.
landbryo
approved these changes
May 21, 2024
|
@landbryo I've merged it in -- sorry I missed this I think? I did merge in the Pantheon one and probably conflated them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #(no issue)
Running
npm run startfailed for two different reasons, I made a video of it but also I can write everything down if you'd likehttps://www.loom.com/share/e69a0d93eba0402996dbff42630bb596
Tasks
Describe the Approach