Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Marcoable trait usage together with Fluent helper #227

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

OzanKurt
Copy link
Contributor

@OzanKurt OzanKurt commented Nov 18, 2024

Copy link

sonarcloud bot commented Nov 18, 2024

@yajra yajra merged commit e7ccbf4 into yajra:master Nov 18, 2024
1 of 2 checks passed
@yajra
Copy link
Owner

yajra commented Nov 18, 2024

Whoops, I think this breaks my current installation, reviewing further.

@yajra
Copy link
Owner

yajra commented Nov 18, 2024

This macro does not work anymore after the patch:

        Button::macro('icon', function (string $icon) {
            /** @var Button $this */
            $this->text("<i class='{$icon} me-1'></i><span>".$this->get('text').'</span>');
            $this->formTitle("<i class='{$icon} me-1'></i><span>".$this->get('formTitle').'</span>');

            return $this;
        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajax batch action not working?
2 participants