Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY-285: Site editors can add a caption to Image Banner | Update Image Banner component to use caption #450

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Dec 19, 2024

IYY-285: Site editors can add a caption to Image Banner

Description of work

Testing Link(s)

Functional Review Steps

Design Review

Accessibility Review

  • Verify the component meets Accessibility requirements

@joetower joetower self-assigned this Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit cc2f732
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/676498f996fb7500089c3a94
😎 Deploy Preview https://deploy-preview-450--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower changed the title feat(IYY-285): add optional image caption to image banners IYY-285: Site editors can add a caption to Image Banner | Update Image Banner component to use caption Dec 19, 2024
@joetower joetower marked this pull request as ready for review December 19, 2024 23:13
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants