-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
September Release Fixes #427
Conversation
Created multidev environment pr-427 for yalesites-platform. |
…n, views basic fix for older storage
@codechefmarc For this one:
We can't do this without opening up the same can of worms with Gin's CSS variables - prompting overrides which aren't great. It would be easier/more advisible to make CKEditor match the other inputs. I pushed a fix for this and marked it as completed above.
|
…can be overriden. Views basic fix for older storage (exclude terms)
…lesites-project into YALB-sept-release-fixes
This will be fixed by yalesites-org/component-library-twig#295 and yalesites-org/atomic#175 |
…ail copy text link
…button fix(YALB-email-copy-change-to-button): update component to use for em…
Release fixes noted in Teams.
Description of work
HIGH PRIORITY! Copy button for email link in Profile is not receiving focus and is not tabbable- (should be a button and not a link) @joetower
Admin theme - red color needs to be tweaked, character limits. @joetower
Mega Menu - Explore All is missing the '>' @joetower - I see it on the dev yalesites-yale-edu, but I don't see it on dev-yalesites-platform, Font Awesome issue?
Mega Menu - we should put an aria-hidden on the repeated first level heading (I mentioned in PR) @codechefmarc
Mega Menu - I need to test this with Fable testers, but we should prepend the first level name to the Explore All link- otherwise a screen reader users hear multiple 'Explore all' links with confusing context @codechefmarc
Motion - will the motion work be added to Levers and Dials before the release? I'll take it out of the release notes until it's complete @joetower
AX toolbars are cutting off the top header area (utility menu in SS) on the site @joetower
Mega footer link forms are extending past the container @codechefmarc
Affiliation taxonomy needs a description under Manage Taxonomy @codechefmarc
We also need the default terms as well @codechefmarc
I did notice that ckeditor5 has a white background, which is fine, but all of our other input fields have that light grey background. I think all the inputs should match. @codechefmarc
Per Franco, Kara's notes, if we are fixing the character limits font color, can we make it match the rest of the text as white. This is in my recommendations for YALB-1387. Maybe we can add the text changes too @joetower
Add updated mega footer icon based on its new version @codechefmarc
Requires PR-293 Component Library
Functional testing steps: