Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1425: Disallow GIF uploads #429

Merged

Conversation

dblanken-yale
Copy link
Contributor

YALB-1425: Firefox - GIF being uploaded to multiple blocks

This is an alternative solution to Pull 428: Convert GIFS to static images

Description of work

  • Disallows gifs for field_media_image

Functional testing steps:

  • Visit media library
  • Attempt to upload a gif file
  • Verify that it will not allow your to upload a gif

This modifies the shared field_media_image field to disallow gif files
across the site as a way to disallow animations.  The idea was that if
you are using a GIF, you probably are animating it.  If you are not,
then you probably want to use a PNG file.
@dblanken-yale dblanken-yale self-assigned this Sep 19, 2023
@dblanken-yale dblanken-yale changed the title YALB-1425: Firefox - GIF being uploaded to multiple blocks YALB-1425: Disallow GIF uploads Sep 19, 2023
@github-actions
Copy link

Visit Site

Created multidev environment pr-429 for yalesites-platform.

Copy link
Contributor

@joetower joetower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblanken-yale Tested and worked well. Straight-forward changes.

@dblanken-yale dblanken-yale merged commit d4009d2 into YALB-1423-1425-1426 Sep 20, 2023
3 checks passed
@dblanken-yale dblanken-yale deleted the YALB-1423-1425-1426-no-gifs-allowed branch September 20, 2023 15:06
@nJim nJim mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants