Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YALB-1385: Feedback: Yale Logo with submenus #435

Merged
merged 1 commit into from
Sep 25, 2023
Merged

YALB-1385: Feedback: Yale Logo with submenus #435

merged 1 commit into from
Sep 25, 2023

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Sep 20, 2023 •
edited by joetower
Loading

YALB-1385: Feedback: Yale Logo with submenus

On mobile, the Yale logo present in the admin-tools section of the menu has no text associated, making it look strange. This hides that list item all together so that it only shows when the vertical menus are not visible.

Description of work

  • Adds css to ys_toolbar to hide the vertical list item for tools-help

Functional testing steps:

  • Visit the PR multidev
  • Verify that the Yale logo appears in the upper left corner when the menu is horizontal
  • Change your resolution to squish the window until the admin menu goes vertical
  • Verify that the Yale logo disappears and the first list item in the Manage menu is Content
  • Ensure that when enlarging the window, you see the Yale logo again when the horizontal menu appears

@dblanken-yale
feat(YALB-1385): hide admin-tools list item
7e9b165 
On mobile, the Yale logo present in the admin-tools section of the menu
has no text associated, making it look strange.  This hides that list
item all together so that it only shows when the vertical menus are not
visible.
@dblanken-yale dblanken-yale self-assigned this Sep 20, 2023
@github-actions
Copy link

Visit Site

Created multidev environment pr-435 for yalesites-platform.

joetower
joetower approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@joetower joetower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblanken-yale 👍 straight-forward change. Looks good!

@dblanken-yale dblanken-yale merged commit d22ed1a into develop Sep 25, 2023
3 checks passed
@dblanken-yale dblanken-yale deleted the YALB-1385-yale-logo-vertical-menu-hide branch September 25, 2023 17:23
@nJim nJim mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joetower joetower joetower approved these changes

Assignees

@dblanken-yale dblanken-yale

Labels
pass code review pass functional review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblanken-yale @joetower