Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY-267: Add Last Updated by to Content admin #797

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Nov 16, 2024

IYY-267: Add Last Updated by to Content admin

Description of work

  • Adds Last Updated By field to Content, Manage Pages, and Manage Posts views listings

Functional testing steps:

  • Login to the site
  • Visit the Content page, the Content -> Manage Pages, and the Content -> Manage Posts pages
  • Verify that there is a new "Last Updated By" field in the list

Screenshot 2024-11-15 at 5 58 13 PM

Copy link

Visit Site

Created multidev environment pr-797 for yalesites-platform.

@dblanken-yale
Copy link
Contributor

Looking great and works as intended. I did have a few questions/requests about this in relation to Manage Events/Profiles.

  1. Manage Events and Content views has a label of "Author", which I looks to be "Last Updated by". Would it be ok to also rename Author to that label as well? Actually, looking at it, Author in Content is different than Author in the Manage Events. I wonder how useful original author is in this over just the last updated by?
  2. For consistency, could we add it to Profiles also since it's then the lone wolf?
  3. And I noticed you placed this at the end after "Updated"; could this be followed in all 5? Just thinking we might want people to get in the habit of always seeing "Updated" and then "Last Updated By".

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the work that was stated, it all looks great. Going to approve but hoping the other questions/requests might be able to be added to this. :D

@codechefmarc
Copy link
Contributor Author

@dblanken-yale - Great call here - constancy is always better. I'll update the others and make sure the label on Events matches too.

@codechefmarc
Copy link
Contributor Author

Ok, updated the other views so all of them match now.

@dblanken-yale
Copy link
Contributor

Looks great! I'll let @miketullo95 and the rest chime in on it, but functions as I expected. :D

Copy link
Contributor

@miketullo95 miketullo95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 😄

@codechefmarc codechefmarc merged commit a344736 into develop Nov 22, 2024
3 checks passed
@codechefmarc codechefmarc deleted the IYY-267--add-last-updated branch November 22, 2024 19:59
This was referenced Nov 26, 2024
@yalesites yalesites mentioned this pull request Dec 12, 2024
@yalesites
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants