Update so that it actually builds. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Advance stack snapshot version. * Fix the breakage caused by changes in Cabal. * Bump minor version. This still leaves many warnings to be addressed. Only erroneous faults were fixed due to urgency.
|
Ping. Thanks for hpack-convert, could this fix be released ? |
|
I made a patch for building |
|
Running into this as well. |
vyorkin
reviewed
Nov 7, 2018
| @@ -1,5 +1,4 @@ | |||
| flags: {} | |||
| packages: | |||
There was a problem hiding this comment.
pls correct me if I'm wrong, but I believe it should be:
packages: []
otherwise I got error:
Error while parsing $.library.dependencies -
expected Array, Object, or String, encountered Null
$ hpack --version
hpack version 0.28.2
|
This works well for me, can it be merged? |
Most of the changes are due to the Pretty class that was added, it seems, in v2.2.0.1-tgt. There were some slightly trickier cases around some data types that don't seem to be used anymore and changes to the Package/ GenericPackge records. Open questions: - This doesn't pass all the tests. The main failures seem to be around quoting in certain rendering situations and in error reporting - Relatedly, how should the new-ish ParseResult monad be incorporated? I opted for parseGenericPackageDescriptionMaybe because I didn't want to infect the rest of the module with an API change, but it's unclear how to exactly recover the old behavior. - Is the style where it needs to be (whitespace/ indentation, ...)?
|
Hey all, I just opened kindaro#1. Would love to discuss if any of you are still interested in this package as of 2020. |
Got it to compile with stack LTS-15.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still leaves many warnings to be addressed. Only erroneous faults
were fixed due to urgency.