Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inst bug #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix inst bug #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/hardware/cpu/isa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,14 @@ void push_handler(od_t *src_od, od_t *dst_od)
{
if (src_od->type == OD_REG)
{
// for test_fork.c: rsp shoud update after acess memory,
// becuase acess memory can trigger page fault, cause to reexecute this instruction.

// src: register
// dst: empty
cpu_reg.rsp = cpu_reg.rsp - 8;
virtual_write_data(
cpu_reg.rsp,
DEREF_VALUE(src_od));
uint64_t tmp_rsp = cpu_reg.rsp - 8;
virtual_write_data(tmp_rsp, DEREF_VALUE(src_od));
cpu_reg.rsp = tmp_rsp;
increase_pc();
cpu_flags.__flags_value = 0;
return;
Expand Down Expand Up @@ -272,13 +274,15 @@ void jne_handler(od_t *src_od, od_t *dst_od)
// last instruction value == 0
increase_pc();
}
cpu_flags.__flags_value = 0;
// Conditional jump instructions do not set flags.
// cpu_flags.__flags_value = 0;
}

void jmp_handler(od_t *src_od, od_t *dst_od)
{
cpu_pc.rip = (src_od->value);
cpu_flags.__flags_value = 0;
// Conditional jump instructions do not set flags.
// cpu_flags.__flags_value = 0;
}

void lea_handler(od_t *src_od, od_t *dst_od)
Expand Down