(feat): yard/multisite-url-fixer #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonvanWijhe
requested review from
a team,
dtakken,
robertbossaert,
mvdhoek1,
ictbeheer,
zoranaism,
WybeBosch,
YvetteNikolov,
laravdiemen and
FreakyWizard
and removed request for
a team
YvetteNikolov
approved these changes
Dec 10, 2024
mvdhoek1
approved these changes
Dec 11, 2024
| { | ||
| add_filter('option_home', [$this, 'fixHomeURL']); | ||
| add_filter('option_siteurl', [$this, 'fixSiteURL']); | ||
| add_filter('network_site_url', [$this, 'fixNetworkSiteURL'], 10, 3); |
There was a problem hiding this comment.
Je zou dit nog kunnen aanpassen naar de first class callable syntax, schijnt ook sneller te zijn.
There was a problem hiding this comment.
Alleen verhoog je daarmee de minimale php versie naar 8.1. Voor nu laat ik het zo.
There was a problem hiding this comment.
There was a problem hiding this comment.
Je verwijst naar php 7.4, draaien er bedrock sites van ons op 7.4 dan?
robertbossaert
approved these changes
Dec 11, 2024
ictbeheer
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from https://github.com/roots/multisite-url-fixer because it is no longer being maintained.