Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 9: Use of insecure HostKeyCallback implementation #5

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarlson
Copy link
Owner

@yarlson yarlson commented Nov 20, 2024

Fixes https://github.com/yarlson/ftl/security/code-scanning/9

To fix the problem, we need to replace the insecure ssh.InsecureIgnoreHostKey() with a secure host key callback. The best way to do this is to use the ssh.FixedHostKey function, which validates the host key against a predefined allow list. This ensures that only trusted host keys are accepted.

  1. Read the allowed host key from a file (e.g., allowed_hostkey.pub).
  2. Parse the public key.
  3. Use ssh.FixedHostKey with the parsed public key to set the HostKeyCallback.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…entation

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant