improve pointer sign

yassinebenaid · Jun 11, 2024 · 0bd8343 · 0bd8343
1 parent 39e72c6
commit 0bd8343
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/dumper.go b/dumper.go
@@ -126,7 +126,9 @@ func (d *dumper) dumpPointer(v reflect.Value) {
 	elem := v.Elem()
 
 	if isPrimitive(elem) {
-		d.write(d.theme.PointerSign.apply("&"))
+		if elem.IsValid() {
+			d.write(d.theme.PointerSign.apply("&"))
+		}
 		d.dump(elem, true)
 		return
 	}
@@ -214,8 +216,6 @@ func isPrimitive(val reflect.Value) bool {
 		case reflect.Pointer:
 			v = v.Elem()
 		default:
-			fmt.Println(v.Kind())
-
 			return false
 		}
 	}

diff --git a/testdata/primitives.txt b/testdata/primitives.txt
@@ -89,7 +89,7 @@ godump.Node {
    PtrTypedBool2: &false,
    PtrTypedString: &"foo bar",
    PtrTypedUintptr: &0x499602d2,
-   Nil: &nil,
+   Nil: nil,
    Func: func(),
    Func2: func(int) float64,
    Func3: func(...*interface {}) interface {},