-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci lint #51
golangci lint #51
Conversation
ccoVeille
commented
Jul 17, 2024
- ci: add golangci-lint configuration file
- chore: no snake case names in Go
- chore: do not overload standard cap function available in Go
- chore: remove useless parameter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 2 2
Lines 187 187
=======================================
Hits 165 165
Misses 21 21
Partials 1 1 ☔ View full report in Codecov by Sentry. |
looks like we've got a conflict at dumper_test.go |
Yes, with my own changes on I expected it to happen |
pushed back @yassinebenaid |
Thanks @ccoVeille |