Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci lint #51

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

ccoVeille
Copy link
Collaborator

  • ci: add golangci-lint configuration file
  • chore: no snake case names in Go
  • chore: do not overload standard cap function available in Go
  • chore: remove useless parameter

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (bf5d318) to head (5e92d79).
Report is 2 commits behind head on master.

Files Patch % Lines
dumper.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files           2        2           
  Lines         187      187           
=======================================
  Hits          165      165           
  Misses         21       21           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yassinebenaid
Copy link
Owner

looks like we've got a conflict at dumper_test.go

@ccoVeille
Copy link
Collaborator Author

Yes, with my own changes on

I expected it to happen

@ccoVeille
Copy link
Collaborator Author

pushed back @yassinebenaid

@yassinebenaid
Copy link
Owner

Thanks @ccoVeille

@yassinebenaid yassinebenaid merged commit 8d9582f into yassinebenaid:master Jul 18, 2024
@ccoVeille ccoVeille deleted the golangci-lint branch July 18, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants