Python 3.12 compatibility fixes #1712
Conversation
distutils has been deprecated for a long time and has finally been removed.
This update of jedi is compatible with python 3.12
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)
third_party/jedi_deps/jedi line 1 at r1 (raw file):
Subproject commit 4e175ca82bbd680cb90f462545c10a8b1c0b5f2e
we didn't need to update typeshed or whatever that dependency is too?
we usually do when updating Jedi.
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)
third_party/jedi_deps/jedi line 1 at r1 (raw file):
Previously, puremourning (Ben Jackson) wrote…
we didn't need to update typeshed or whatever that dependency is too?
we usually do when updating Jedi.
I have checked. third_party/jedi_deps/parso had no newer release.
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)
third_party/jedi_deps/jedi line 1 at r1 (raw file):
Previously, bstaletic (Boris Staletic) wrote…
I have checked. third_party/jedi_deps/parso had no newer release.
Oh and typeshed itself is vendored by jedi, not a submodule.
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)
There was a problem hiding this comment.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
- Coverage 95.44% 95.40% -0.04%
==========================================
Files 83 83
Lines 8123 8122 -1
Branches 164 165 +1
==========================================
- Hits 7753 7749 -4
- Misses 320 322 +2
- Partials 50 51 +1 |
|
Thanks for sending a PR! |
CI is still not ready for python 3.12. Stay tuned.
This change is