Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for EarningsInterface#assetHistoricEarnings #271

Merged
merged 7 commits into from
Apr 13, 2022
Merged

test: Add test for EarningsInterface#assetHistoricEarnings #271

merged 7 commits into from
Apr 13, 2022

Conversation

karelianpie
Copy link
Contributor

@karelianpie karelianpie commented Apr 2, 2022 •
edited
Loading

Description

  • Add test for EarningsInterface#assetHistoricEarnings;
  • Minor refactorings of EarningsInterface#assetHistoricEarnings

Related Issue

#211

@karelianpie karelianpie self-assigned this Apr 2, 2022
@karelianpie karelianpie requested review from jstashh and xgambitox April 2, 2022 08:47
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 44.36 KB (+0.16% 🔺)
dist/sdk.esm.js 44.74 KB (+0.19% 🔺)

@karelianpie karelianpie changed the title test: Add test for EarningsInterface#assetHistoricEarnings test: Add test for EarningsInterface#assetHistoricEarnings Apr 2, 2022
@karelianpie karelianpie changed the base branch from master to fix/eslint April 3, 2022 03:13
@karelianpie karelianpie changed the base branch from fix/eslint to master April 3, 2022 03:14
@karelianpie karelianpie changed the base branch from master to fix/eslint April 3, 2022 04:24
@karelianpie karelianpie changed the base branch from fix/eslint to master April 3, 2022 04:24
@karelianpie karelianpie force-pushed the test/asset-historic-earnings branch from 2e0929c to a0585a8 Compare April 11, 2022 22:06
jstashh
jstashh approved these changes Apr 12, 2022
View reviewed changes
src/interfaces/earnings.ts Show resolved Hide resolved
@xgambitox xgambitox merged commit 5c31eb5 into master Apr 13, 2022
@xgambitox xgambitox deleted the test/asset-historic-earnings branch April 13, 2022 07:02
jstashh pushed a commit that referenced this pull request May 31, 2022
@karelianpie @jstashh
test: Add test for EarningsInterface#assetHistoricEarnings (#271)
3b67f7c 
* test: Add test for EarningsInterface#assetHistoricEarnings

* fix: Type `AssetHistoricEarningsResponse`

* refactor: Use nullish coalescing operator

* fix: Types

* fix: Remove BlockLabel

* fix: no-useless-computed-key

* fix: Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FiboApe FiboApe FiboApe approved these changes

@jstashh jstashh jstashh approved these changes

@xgambitox xgambitox Awaiting requested review from xgambitox

Assignees

@karelianpie karelianpie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karelianpie @jstashh @FiboApe @xgambitox