Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndsDaemon.java:63-64: Refactor this class to use... #934

Closed
alex-palevsky opened this issue Sep 18, 2015 · 3 comments
Closed

EndsDaemon.java:63-64: Refactor this class to use... #934

alex-palevsky opened this issue Sep 18, 2015 · 3 comments

Comments

@alex-palevsky
Copy link
Contributor

Puzzle 567-359f8c66 in src/main/java/com/rultor/agents/daemons/EndsDaemon.java:63-64 has to be resolved: Refactor this class to use less objects and remove checkstyle exception above.... The puzzle was created by Yegor Bugayenko on 18-Sep-2015.

If you have any technical questions, don't ask me, submit new tickets instead
@alex-palevsky alex-palevsky mentioned this issue Sep 18, 2015
Closed
@alex-palevsky
Copy link
Contributor Author

@yegor256 I set the milestone to 2.0 since there is nothing set yet

@alex-palevsky alex-palevsky added this to the 2.0 milestone Sep 18, 2015
original-brownbear added a commit to original-brownbear/rultor that referenced this issue Feb 13, 2016
@original-brownbear
\yegor256#934 Refactored EndsDaemon to use ShellCommand
dc1f6b1 
* Created new ShellCommand class to encapsulated running a command in a shell
* Used ShellCommand to make EndsDaemon use fewer objects and remove duplicate
logic for sanitizing and running commands in EndsDaemon
@original-brownbear original-brownbear mentioned this issue Feb 13, 2016
Closed
@original-brownbear
Copy link
Contributor

Suggested refactoring here #1004 :)

original-brownbear added a commit to original-brownbear/rultor that referenced this issue Feb 16, 2016
@original-brownbear
yegor256#934 corrected version in com.rultor.agents.daemons.ShellCommand
318adde
rultor pushed a commit that referenced this issue Feb 16, 2016
@original-brownbear @rultor
\#934 Refactored EndsDaemon to use ShellCommand
77be2ed 
* Created new ShellCommand class to encapsulated running a command in a shell
* Used ShellCommand to make EndsDaemon use fewer objects and remove duplicate
logic for sanitizing and running commands in EndsDaemon
rultor pushed a commit that referenced this issue Feb 16, 2016
@original-brownbear @rultor
#934 corrected version in com.rultor.agents.daemons.ShellCommand
c0647b9
@alex-palevsky
Copy link
Contributor Author

@original-brownbear The issue should be closed..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-palevsky @original-brownbear