#934 Refactored EndsDaemon to use ShellCommand

[original-brownbear]

This addresses #934:

• Created new ShellCommand class to encapsulated running a command in a shell
• Used ShellCommand to make EndsDaemon use fewer objects and remove duplicate
  logic for sanitizing and running commands in EndsDaemon

[alex-palevsky]

@original-brownbear I will find a reviewer for your pull requests shortly, thanks for contribution!

[alex-palevsky]

@pinaf help us to review this

[pinaf]

@original-brownbear 1.62

[pinaf]

@original-brownbear 1 minor comment

[original-brownbear]

@pinaf dealt with it :)

[pinaf]

@rultor merge

[rultor]

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@rultor try to merge

[rultor]

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 9min)

[original-brownbear]

@alex-palevsky this can be closed given that it is now merged right ?

[pinaf]

@yegor256 @original-brownbear It should have been closed automatically by github after merge. Weird.

[pinaf]

@rultor deploy

[rultor]

@rultor deploy

@pinaf Thanks for your request. @yegor256 Please confirm this.

[original-brownbear]

@pinaf I think this is the case discussed here #1002.
The MR only closes when the merge could have been outright fast forwarded and the rebase Rultor does would be without effect. If there were actually new commits in between that needed to be rebased upon => hashes change => Github doesn't recognize the merge .

[alex-palevsky]

@alex-palevsky this can be closed given that it is now merged right ?

@original-brownbear just close it yourself please

[original-brownbear]

@alex-palevsky ok :)

[alex-palevsky]

@pinaf Thanks so much! Your account was topped up for 20 mins (transaction ID is AP-4CC02639S5753930T, the task took 172 hours and 36 mins); extra minutes for review comments (c=5); +20 added to your rating, current score is: +6503