README should have what problems Rultor solves #998

bernardosulzbach · 2016-02-04T15:52:50Z

Closes #997

Also pluralized "Problem" as Rultor solves more than a single problem.
Wrote paragraphs instead of an enumeration so that the README looks more
like thorough documentation and less like a TODO list.

Closes #997 Also pluralized "Problem" as Rultor solves more than a single problem. Wrote paragraphs instead of a enumeration so that the README looks more like thorough documentation and less like a TODO list.

alex-palevsky · 2016-02-04T17:21:28Z

@mafagafogigante Thanks for the pull request, let me find a reviewer..

alex-palevsky · 2016-02-04T17:26:27Z

@mkordas could you review this pull request

mkordas · 2016-02-04T21:48:03Z

@mafagafogigante I'm on it

mkordas · 2016-02-04T21:48:25Z

README.md

+and makes errors more easily reproducible.
+
+Additionally, because of the way Rultor integrates with modern issue trackers,
+all the logs are stored in the meaningful ticket. Making vital information


@mafagafogigante what do you mean by meaningful ticket?

The ticket (or issue, using GitHub vocabulary) from which it was invoked. If you couldn't figure it out, it is clearly not good enough. Will adapt.

mkordas · 2016-02-04T21:53:41Z

@mafagafogigante please see a few comments above

bernardosulzbach · 2016-02-04T22:01:16Z

@mkordas I am on it.

bernardosulzbach · 2016-02-04T22:18:47Z

@mkordas Added another commit on top of it. A merger may squash them if necessary. If you want me to do it, just say it.

mkordas · 2016-02-04T22:43:54Z

@mafagafogigante can you always address messages to someone? http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html#4.-avoid-noise-—-address-your-comments

mkordas · 2016-02-04T22:47:05Z

README.md

+mentioned. Making vital information easily accessible to all developers.
+
+Lastly, Rultor provides an integrated and humanized interface to DevOps tools,
+as a human-readable sentence suffices to trigger a merge or a release.



@mafagafogigante that's true what you've written above, but what about entire idea of pre-flight builds? Please watch https://www.youtube.com/watch?v=6SfIc5ff-8U

mkordas · 2016-02-04T22:48:13Z

@mafagafogigante squashing is not necessary unless history is not too messy. Merger cannot squash commits, as Rultor will be merging :)

bernardosulzbach · 2016-02-04T22:53:50Z

can you always address messages to someone?

@mkordas I will do my best to remember it here. Although I can't help but disagree that "a ticket is a conversation between two people", at least not always. However, as this is not my project, your rules prevail.

but what about entire idea of pre-flight builds

I will watch the video and get back to you.

bernardosulzbach · 2016-02-04T23:15:11Z

Merger cannot squash commits, as Rultor will be merging :)

@mkordas Yes, that comment would be nonsensical for any repository which uses Rultor. And I made it in the Rultor repository itself...

I think I understood your last comment. I missed a huge point of Rultor. Preventing master from being broken is in the end one of the problems it solves.

mkordas · 2016-02-05T10:40:12Z

@mafagafogigante

I will do my best to remember it here

So please edit your comment above :)

Although I can't help but disagree that "a ticket is a conversation between two people"

True, I think It's pretty unfortunate statement. You can raise PR or issue to Yegor's blog. I think it's ok to address message to a group of people by listing their nicknames or even mentioning entire teams.

mkordas · 2016-02-05T10:40:44Z

@mafagafogigante After your recent changes now description looks great, thanks for contribution!

mkordas · 2016-02-05T10:40:47Z

@rultor merge

rultor · 2016-02-05T10:42:38Z

@rultor merge

@mkordas Thanks for your request. @yegor256 Please confirm this.

bernardosulzbach · 2016-02-05T14:27:52Z

@mkordas Done editing. Did not edit the first comment ("the issue") because it would look like I foresaw who was going to check it.

mkordas · 2016-02-05T16:12:09Z

@mafagafogigante right, PR description should stay as it is :)

mkordas · 2016-02-08T08:10:40Z

@yegor256 please review and confirm merge if PR is fine

yegor256 · 2016-02-09T04:00:17Z

@rultor try to merge

rultor · 2016-02-09T04:26:36Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-02-09T04:38:39Z

@rultor try to merge

@mafagafogigante @yegor256 Oops, I failed. You can see the full log here (spent 12min)

[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building rultor 2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ rultor ---
[INFO] Deleting /home/r/repo/target
[INFO] 
[INFO] --- exec-maven-plugin:1.4.0:exec (jekyll-build) @ rultor ---
Configuration file: /home/r/repo/src/jekyll/_config.yml
\u001b[31m  Dependency Error: Yikes! It looks like you don't have jekyll-sass or one of its dependencies installed. In order to use Jekyll as currently configured, you'll need to install this gem. The full error message from Ruby is: 'cannot load such file -- jekyll-sass' If you run into trouble, you can find helpful resources at http://jekyllrb.com/help/! \u001b[0m
jekyll 3.1.1 | Error:  jekyll-sass
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.046 s
[INFO] Finished at: 2016-02-09T04:37:30+00:00
[INFO] Final Memory: 16M/276M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:exec (jekyll-build) on project rultor: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:exec (jekyll-build) on project rultor: Command execution failed.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed.
    at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:276)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
Caused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
    at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
    at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:660)
    at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:265)
    ... 21 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container e7861181f86c18da34d73dadb7f376d01ae5cd9e8166b18f740b119c95cb204b is dead
Tue Feb  9 04:38:35 UTC 2016

mkordas · 2016-02-09T07:15:11Z

@yegor256 do you know what needs to be fixed to make rultor working again for rultor? :)

original-brownbear · 2016-02-09T12:35:33Z

@mkordas suggested fix for the build here #1002 :)

mkordas · 2016-02-09T12:44:27Z

@original-brownbear thanks, you should notify @yegor256 about it

mkordas · 2016-02-12T16:50:37Z

@yegor256 ping

yegor256 · 2016-02-12T19:48:01Z

@mkordas we'll try here right after #1002 is merged

mkordas · 2016-02-12T22:00:33Z

@yegor256 #1002 is merged, please proceed here

yegor256 · 2016-02-12T22:29:32Z

@rultor merge

rultor · 2016-02-12T22:43:11Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-02-12T22:54:15Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 11min)

mkordas · 2016-02-12T22:58:20Z

@mafagafogigante can you please close the PR? It was already merged.

bernardosulzbach · 2016-02-12T23:34:37Z

@mkordas Done.

mkordas · 2016-02-12T23:42:16Z

@mafagafogigante thanks!

mkordas · 2016-02-12T23:42:20Z

@rultor deploy

rultor · 2016-02-12T23:57:13Z

@rultor deploy

@mkordas Thanks for your request. @yegor256 Please confirm this.

alex-palevsky · 2016-02-21T17:54:44Z

@mkordas 10 mins added to @original-brownbear account (our architect), payment ID is AP-5LY597113C799024P, since quality is good here

README should have what problems Rultor solves

e8100e1

Closes #997 Also pluralized "Problem" as Rultor solves more than a single problem. Wrote paragraphs instead of a enumeration so that the README looks more like thorough documentation and less like a TODO list.

alex-palevsky added CR labels Feb 4, 2016

mkordas reviewed Feb 4, 2016
View reviewed changes

Updated README section according to feedback

fe65f9c

mkordas reviewed Feb 4, 2016
View reviewed changes

README should also mention pre-flight builds

22ff5cb

original-brownbear mentioned this pull request Feb 9, 2016

fixing site target by running jekyll in bundle context, see #1001 #1002

Closed

bernardosulzbach closed this Feb 12, 2016

bernardosulzbach mentioned this pull request Feb 13, 2016

README does not explain why someone should use Rultor #997

Closed

README should have what problems Rultor solves #998

README should have what problems Rultor solves #998

Conversation

bernardosulzbach commented Feb 4, 2016

alex-palevsky commented Feb 4, 2016

alex-palevsky commented Feb 4, 2016

mkordas commented Feb 4, 2016

mkordas Feb 4, 2016

Choose a reason for hiding this comment

bernardosulzbach Feb 4, 2016

Choose a reason for hiding this comment

mkordas commented Feb 4, 2016

bernardosulzbach commented Feb 4, 2016

bernardosulzbach commented Feb 4, 2016

mkordas commented Feb 4, 2016

mkordas Feb 4, 2016

Choose a reason for hiding this comment

mkordas commented Feb 4, 2016

bernardosulzbach commented Feb 4, 2016

bernardosulzbach commented Feb 4, 2016

mkordas commented Feb 5, 2016

mkordas commented Feb 5, 2016

mkordas commented Feb 5, 2016

rultor commented Feb 5, 2016

bernardosulzbach commented Feb 5, 2016

mkordas commented Feb 5, 2016

mkordas commented Feb 8, 2016

yegor256 commented Feb 9, 2016

rultor commented Feb 9, 2016

rultor commented Feb 9, 2016

mkordas commented Feb 9, 2016

original-brownbear commented Feb 9, 2016

mkordas commented Feb 9, 2016

mkordas commented Feb 12, 2016

yegor256 commented Feb 12, 2016

mkordas commented Feb 12, 2016

yegor256 commented Feb 12, 2016

rultor commented Feb 12, 2016

rultor commented Feb 12, 2016

mkordas commented Feb 12, 2016

bernardosulzbach commented Feb 12, 2016

mkordas commented Feb 12, 2016

mkordas commented Feb 12, 2016

rultor commented Feb 12, 2016

alex-palevsky commented Feb 21, 2016