Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: publish 조건 수정 #4

Merged
merged 1 commit into from
Sep 16, 2024
Merged

cicd: publish 조건 수정 #4

merged 1 commit into from
Sep 16, 2024

Conversation

yesinkim
Copy link
Owner

No description provided.

tags:
- '*'
release:
types: [created]

jobs:
pypi-publish:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review:

  1. Changes to Trigger Action:

    • Changed the trigger from push with a tag match to a release trigger that only runs on "created" releases. This change is reasonable if you want to publish to PyPI only when a new release is created, not on every push (which could potentially become noisy).
  2. Risk and Improvement Suggestions:

    • Security Risk: Consider implementing safeguards to prevent accidental or unauthorized releases.
    • Workflow Understanding: Ensure this action does not cause unintended publishing or errors due to misconfigured or untested releases.
    • Versioning: Be explicit about version numbers being released to prevent unintentional overwritten existing versions on PyPI.
    • Testing: It's helpful to thoroughly test the workflow to ensure it handles different scenarios well.
  3. Future Improvements:

    • Include Tests: Add tests to automate validation of the release process in your workflows.
    • Error Handling: Implement error handling mechanisms to catch and report any issues during the release process.
    • Notification System: Consider setting up notifications for successful or failed releases.
    • Documentation: Document the workflow thoroughly so others can understand and maintain it easily.

Overall Assessment:

The code patch seems to provide a solid basis for publishing Python distributions to PyPI upon the creation of a release. However, to enhance robustness, consider addressing the identified risks and implementing suggested improvements.

@yesinkim yesinkim merged commit 2ced12f into main Sep 16, 2024
2 checks passed
@yesinkim yesinkim deleted the feature/cicdtest branch September 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant