fix: fetch the bls public key on demand

yetanotherco · Nov 25, 2024 · 7fe06ca · 7fe06ca
1 parent 0df3a3b
commit 7fe06ca
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/telemetry_api/lib/telemetry_api/bls_signature_verifier.ex b/telemetry_api/lib/telemetry_api/bls_signature_verifier.ex
@@ -1,4 +1,4 @@
-defmodule BlsSignatureVerifier do
+defmodule BLSSignatureVerifier do
   def verify(signature, public_key, message) do
     # Encode the args as hex
     args = [

diff --git a/telemetry_api/lib/telemetry_api/contract_managers/bls_apk_registry.ex b/telemetry_api/lib/telemetry_api/contract_managers/bls_apk_registry.ex
@@ -1,4 +1,4 @@
-defmodule BlsApkRegistry do
+defmodule BLSApkRegistry do
   require Logger
 
   @aligned_config_file System.get_env("ALIGNED_CONFIG_FILE")
@@ -34,7 +34,7 @@ defmodule BlsApkRegistry do
   end
 
   def get_operator_bls_pubkey(operator_address) do
-    case BlsApkRegistry.get_registered_pubkey(operator_address)
+    case BLSApkRegistry.get_registered_pubkey(operator_address)
          |> Ethers.call() do
       {:ok, data} ->
         data

diff --git a/telemetry_api/lib/telemetry_api/operators.ex b/telemetry_api/lib/telemetry_api/operators.ex
@@ -150,9 +150,11 @@ defmodule TelemetryApi.Operators do
         {:error, :bad_request, "Provided address does not correspond to any registered operator"}
 
       operator ->
-        with {:ok, _} <-
-               BLSSignatureVerifier.verify(signature, bls_public_key, message_hash) do
-          update_operator(operator, changes)
+        with {:ok, bls_public_key} <- BLSApkRegistry.get_operator_bls_pubkey(address) do
+          with {:ok, _} <-
+                 BLSSignatureVerifier.verify(signature, bls_public_key, message_hash) do
+            update_operator(operator, changes)
+          end
         end
     end
   end

diff --git a/telemetry_api/lib/telemetry_api/operators/operator.ex b/telemetry_api/lib/telemetry_api/operators/operator.ex
@@ -13,7 +13,6 @@ defmodule TelemetryApi.Operators.Operator do
     field :eth_rpc_url_fallback, :string
     field :eth_ws_url, :string
     field :eth_ws_url_fallback, :string
-    field :bls_public_key, :string
 
     timestamps(type: :utc_datetime)
   end
@@ -32,9 +31,8 @@ defmodule TelemetryApi.Operators.Operator do
       :eth_rpc_url_fallback,
       :eth_ws_url,
       :eth_ws_url_fallback,
-      :bls_public_key
     ])
-    |> validate_required([:address, :id, :name, :stake, :bls_public_key])
+    |> validate_required([:address, :id, :name, :stake])
   end
 end