-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): Docker compose for all components #1044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaus993
force-pushed
the
docker-compose
branch
4 times, most recently
from
September 24, 2024 21:57
b6536b9
to
52eb45e
Compare
This makes later compilations use clang rather than gcc for compiling C
klaus993
force-pushed
the
docker-compose
branch
from
October 17, 2024 21:44
4616af9
to
2f40606
Compare
As localhost is already the default
Oppen
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by the demolition crew.
Thanks! |
JuArce
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just two comments
- Update readme for send proofs targets
- Calculate gas price in every transaction sent on start up
klaus993
force-pushed
the
docker-compose
branch
from
October 22, 2024 17:48
598e4d2
to
1a923cb
Compare
As a different job, when another PR has the send proofs job queued, it's executed before the cleanup
uri-99
approved these changes
Oct 22, 2024
avilagaston9
pushed a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Mariano Nicolini <[email protected]> Co-authored-by: samoht9277 <[email protected]>
PatStiles
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Mariano Nicolini <[email protected]> Co-authored-by: samoht9277 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
To test you can follow instructions on
docker/README.md