-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable verifiers #1090
Merged
JuArce
merged 70 commits into
staging
from
1082-add-a-bitmap-in-ethereum-to-disable-verifiers
Oct 18, 2024
Merged
feat: disable verifiers #1090
JuArce
merged 70 commits into
staging
from
1082-add-a-bitmap-in-ethereum-to-disable-verifiers
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
uri-99
requested changes
Sep 30, 2024
uri-99
reviewed
Oct 1, 2024
uri-99
requested changes
Oct 1, 2024
uri-99
reviewed
Oct 1, 2024
uri-99
reviewed
Oct 1, 2024
uri-99
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still missing to review a couple of files
uri-99
requested changes
Oct 17, 2024
entropidelic
approved these changes
Oct 17, 2024
uri-99
approved these changes
Oct 18, 2024
JuArce
approved these changes
Oct 18, 2024
PatStiles
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: IAvecilla <[email protected]> Co-authored-by: Mariano Nicolini <[email protected]> Co-authored-by: Uriel Mihura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pr introduces proving systems or verifiers blacklisting through a new bitmap field in the
ServiceManager
contract. The batcher and operator, before doing a verification, they make sure that the proving system is indeed whitelisted by callingisVerifierValid
function in theServiceManager
contract.It also includes the verification for disabled verifiers in the operators and the batcher logic. For the batcher it will now check for every new block if the disabled verifiers have changed, in the afirmative case it checks all the proofs inside the batcher queue and remove all of them indistinctly if it was a proof using the disabled verifier or not.
Test
You can test this following these steps:
make batcher_send_burst_groth16
just to keep generating new proofs and avoid problems trying to submit repeated batches.disableVerifier(uint8)
. TheVERIFIER_ID=3
variable will disable the SP1 verifier:make batcher_send_sp1_task
.make batcher_send_sp1_task
.If you want to try and disable all the other verifiers run the same command mentioned above changing the
VERIFIER_ID
that is the ID corresponding to the
ProvingSystemId
enum in theproving_systems.go
file, beingGnarkPlonkBls12_381
the id 0.Disabled verifiers in the batch queue testing
Start the Aligned components (anvil, aggregator, and operator).
Open the batcher's configuration file at
config-files/config-batcher.yaml
and adjust the following parameters:Run the batcher:
make batcher_start_local
Send 3 proofs using any of the verifiers:
make batcher_send_sp1_task
make batcher_send_risc0_task
make batcher_send_groth16_bn254_task
Disable the SP1 verifier:
make verifier_disable_devnet VERIFIER_ID=3
Verify that all the clients stop and encounter an
BatchReset
error. The batcher's queue should now be empty.This closes #1082