You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds new data to be updated for each operator on the telemetry service, which includes:
eth_rpc_url
eth_rpc_url_fallback
eth_ws_url
eth_ws_url_fallback
version (this one was already present)
The implementation is also updated from the operator's side.
Testing
In order to test, the following steps were taken:
Start anvil and the aggregator with:
make anvil_start_with_block_time
make aggregator_start
Build and register operator with:
make build_operator
make operator_full_registration CONFIG_FILE=config-files/config-operator-1.yaml
Start telemetry service with:
make telemetry_clean_db
make telemetry_run_db
make telemetry_start
Go to http://localhost:4001/api/operators and you should see the operator with its data fields. Some of them, like the version and RPC related should be set as null, since the operator is not up yet.
Start the operator with ./operator/build/aligned-operator start --config ./config-files/config-operator-1.yaml
Go to http://localhost:4001/api/operators and you should see the operator, now with all fields with a certain value, including version and RPC related.
It is also highly advisable to test previous functionality as it's described on this already merged PR
Tested on my machine, and it worked fine. One thing, in the diff I see you changed the eigenlayer-middleware, is that on purpose?
No, I haven't touched anything related to that. There was a merge from staging branch, so maybe it was an auto merge error? eigenlayer-middleware is a submodule, I checked and the staging branch points to the same commit as this one, so Idk what caused that diff.
Tested on my machine, and it worked fine. One thing, in the diff I see you changed the eigenlayer-middleware, is that on purpose?
No, I haven't touched anything related to that. There was a merge from staging branch, so maybe it was an auto merge error? eigenlayer-middleware is a submodule, I checked and the staging branch points to the same commit as this one, so Idk what caused that diff.
My bad. The submodule commit was in fact different from the one in staging branch. Good catch!
everything worked correctly, but I am thinking that it does not make much sense to register the http and websocket providers URL separately. Since the protocol and the API key are stripped from the URL, they will always be the same, or am I missing something?
nvm, talked with @JuArce and the current behaviour is correct
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new data to be updated for each operator on the telemetry service, which includes:
eth_rpc_urleth_rpc_url_fallbacketh_ws_urleth_ws_url_fallbackversion(this one was already present)The implementation is also updated from the operator's side.
Testing
In order to test, the following steps were taken:
make anvil_start_with_block_timemake aggregator_startmake build_operatormake operator_full_registration CONFIG_FILE=config-files/config-operator-1.yamlmake telemetry_clean_dbmake telemetry_run_dbmake telemetry_starthttp://localhost:4001/api/operatorsand you should see the operator with its data fields. Some of them, like the version and RPC related should be set as null, since the operator is not up yet../operator/build/aligned-operator start --config ./config-files/config-operator-1.yamlhttp://localhost:4001/api/operatorsand you should see the operator, now with all fields with a certain value, including version and RPC related.It is also highly advisable to test previous functionality as it's described on this already merged PR