refactor: zkquiz setup and testing locally/devnet #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Also, currently batches must be at least size 2. If you only send this proof, the batch will not be finalized by the batcher. If it is a local devnet example, you could send this proof twice to make the batch finalize, or clarify that the user must in parallel send another proof (such as make batcher_send_risc0_burst)
MarcosNicolau
force-pushed
the
refactor-zk-quiz-testing
branch
from
ebd81ae to
5242061
Compare
uri-99
approved these changes
Oct 7, 2024
entropidelic
reviewed
Oct 8, 2024
|
left a small comment on the readme, but aside from that it looks good! |
uri-99
requested changes
Oct 8, 2024
entropidelic
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pr refactors zkquiz example so that testing it locally becomes easier.
Testing
To test this, you can follow this guide.