Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CI): optimize rust deps for Docker CI #1278

Merged
merged 165 commits into from
Nov 4, 2024
Merged

feat(CI): optimize rust deps for Docker CI #1278

merged 165 commits into from
Nov 4, 2024

Conversation

samoht9277
Copy link
Collaborator

@samoht9277 samoht9277 commented Oct 16, 2024 •
edited
Loading

Optimization for rust builds inside the CI

Description

This PR aims to improve build times by caching dependencies.

To test this, simply run the Send proofs to network / Test network with Docker Compose GitHub workflow from this branch. If no caché is found, it will compile all, like it has been always doing. If caché is found, it will skip through the cached steps, improving time overall.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue -> feat(CI): Optimize rust builds #1265
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@klaus993
Add Dockerfiles
8757db5
@klaus993
Add config files for docker
2612361
@klaus993
Add docker compose manifest with all services but the batcher
b874482
@klaus993
Add batcher Dockerfile and config files
41a7218
@klaus993
Aggregator config fixes
cff6035
@klaus993
Fix mit mock tokens command
df68e7c
@klaus993
Add localstack
f40443b
@klaus993
Add batcher to docker compose
67fe122
@klaus993
Copy all config files for anvil
3d73c1c
@klaus993
Send env vars via docker compose instead of cli parameter
9e657a1
@klaus993
Add ca-certificates package
e09d3e1
@klaus993
Add contracts to batcher
efee3aa
@klaus993
[WIP] make batcher work
d716539
@klaus993
Fix operator docker config
035d94f
@klaus993
Use profiles in docker compose with groups of services
8c477ab
@klaus993
Remove sleep hack from docker commands
abdba53
@klaus993
Add Makefile targets to run and kill stack with docker compose
2416df3
@klaus993
Add docker-build Makefile target
ad184f6
@klaus993
Add docker compose dummy services
6b2d4f7
@klaus993
Make base image build in macOS
f203e1f 
This makes later compilations use clang rather than gcc for compiling C
@klaus993
Configure operator build to use GCC and CGO
d918eaf
@klaus993
Change order of build because of dependencies
54fa33b
@klaus993
Remove unnecessary .env files
bb47484
@klaus993
Make batcher and operator compile in linux/arm64
66d4ad0
@klaus993
Send GOARCH env var via command line, according to the host's arch
5f34065
@klaus993
Build eigenlayer-cli separately
7b00b2a
@klaus993
Build aligned cli inside batcher
ddf4ded
@klaus993
Remove commented code
35e850f
@klaus993
Compile aligned
d7794b3
@klaus993
Add Makefile targets to send burst of proofs on docker
796d57c
@samoht9277 samoht9277 changed the title [WIP] Optimize rust deps for Docker CI. feat(CI): optimize rust deps for Docker CI. Oct 23, 2024
@klaus993 klaus993 changed the title feat(CI): optimize rust deps for Docker CI. feat(CI): optimize rust deps for Docker CI Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Changes to gas cost

Generated at commit: 429fcc9efe0b6f931f69959473afc210f9a4e1db, compared to commit: 192a535aa39bbad8cada32b9460bf59e33081685

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask -123 ✅ -0.17%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,771,213 (0) createNewTask
receive		 53,923 (-12)
21,169 (0)		 -0.02%
0.00%		 73,843 (-123)
44,690 (-187)		 -0.17%
-0.42%		 74,117 (+66)
45,064 (0)		 +0.09%
0.00%		 74,786 (-84)
45,064 (0)		 -0.11%
0.00%		 256 (0)
256 (0)

@samoht9277 samoht9277 force-pushed the docker-cache-deps branch 2 times, most recently from a64f28f to 74d08ed Compare October 29, 2024 17:08
@MauroToscano MauroToscano merged commit c980252 into staging Nov 4, 2024
1 check passed
@MauroToscano MauroToscano deleted the docker-cache-deps branch November 4, 2024 16:30
PatStiles pushed a commit that referenced this pull request Nov 6, 2024
@samoht9277 @klaus993
@entropidelic @JuArce @PatStiles
feat(CI): optimize rust deps for Docker CI (#1278)
9642b99 
Co-authored-by: Klaus Lungwitz <[email protected]>
Co-authored-by: Mariano Nicolini <[email protected]>
Co-authored-by: Klaus @ LambdaClass <[email protected]>
Co-authored-by: JuArce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaus993 klaus993 klaus993 left review comments

@JuArce JuArce JuArce approved these changes

@MauroToscano MauroToscano MauroToscano approved these changes

Assignees

@samoht9277 samoht9277

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(CI): Optimize rust builds
5 participants
@samoht9277 @MauroToscano @klaus993 @JuArce @entropidelic