test: aggregator bump fee #1297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-the-fee-v2' into test-aggregator-bump-fee
MarcosNicolau
commented
Oct 21, 2024
| ) external onlyAggregator { | ||
| uint256 initialGasLeft = gasleft(); | ||
|
|
||
| if (i < 4) { |
There was a problem hiding this comment.
You can modify this 4 to a higher value to test higher retries. Don't forget to re-deploy the contracts.
| @@ -74,11 +74,11 @@ func NewAvsWriterFromConfig(baseConfig *config.BaseConfig, ecdsaConfig *config.E | |||
| func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMerkleRoot [32]byte, senderAddress [20]byte, nonSignerStakesAndSignature servicemanager.IBLSSignatureCheckerNonSignerStakesAndSignature) (*types.Receipt, error) { | |||
| txOpts := *w.Signer.GetTxOpts() | |||
| txOpts.NoSend = true // simulate the transaction | |||
| tx, err := w.AvsContractBindings.ServiceManager.RespondToTaskV2(&txOpts, batchMerkleRoot, senderAddress, nonSignerStakesAndSignature) | |||
| tx, err := w.AvsContractBindings.ServiceManager.RespondToTaskV2(&txOpts, batchMerkleRoot, senderAddress, nonSignerStakesAndSignature, new(big.Int).SetUint64(5)) | |||
There was a problem hiding this comment.
If you modify the contract, make sure you pass a larger number so that this transaction does not revert.
|
|
||
| if err != nil { | ||
| // Retry with fallback | ||
| tx, err = w.AvsContractBindings.ServiceManagerFallback.RespondToTaskV2(&txOpts, batchMerkleRoot, senderAddress, nonSignerStakesAndSignature) | ||
| tx, err = w.AvsContractBindings.ServiceManagerFallback.RespondToTaskV2(&txOpts, batchMerkleRoot, senderAddress, nonSignerStakesAndSignature, new(big.Int).SetUint64(5)) |
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
…p-the-fee-v2' into test-aggregator-bump-fee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test aggregator bump fee
Description
This pr is to test #1286. The
respondToTaskV2function inAlignedServiceManagerContracthas been modified to successfully respond if anithhigher or equal to4is provided, this is to avoid reverts in next iterations.Then, the context timeout is modified to
1sec. This way, the context will be done faster than the blockWaitForTransactionReceiptso a new iteration will start and a new tx will be sent with a highergasPrice.Testing
To test it, just setup a local devnet as usual and sends proofs of any type.
You should see in the logs how the gas price is increased after every iteration:
[2024-10-18 16:44:41.607 -03] INFO (pkg/aggregator.go:270) Sending aggregated response onchain {"batchIdentifierHash":"0x4a99727c126f5de1585ae54b493f046d3c0bfdb56fb4a59711427b0f1dd098c1","taskIndex":0} [2024-10-18 16:44:41.607 -03] INFO (pkg/aggregator.go:299) - Locked Wallet Resources: Sending aggregated response for batch%!(EXTRA string=merkleRoot, string=da4f89d5540acf7e2aec9eadc60da129beb23c9da4b0346a53d7fd360cddd7ad, string=senderAddress, string=7969c5ed335650692bc04293b07f5bf2e7a673c0, string=batchIdentifierHash, string=4a99727c126f5de1585ae54b493f046d3c0bfdb56fb4a59711427b0f1dd098c1) [2024-10-18 16:44:41.704 -03] INFO (chainio/avs_writer.go:149) Simulated cost {"cost":"262651003677114"} [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:167) Batch RespondToTaskFeeLimit {"RespondToTaskFeeLimit":"1500000010500000"} [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:199) Aggregator balance {"balance":"9999998939516696560420"} [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:217) Batcher balance {"balance":"1001070133935012705"} [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:108) Sending ResponseToTask transaction for 1th with a gas price of 1100000015 [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:149) Simulated cost {"cost":"262651003677114"} [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:167) Batch RespondToTaskFeeLimit {"RespondToTaskFeeLimit":"1500000010500000"} [2024-10-18 16:44:41.705 -03] INFO (chainio/avs_writer.go:199) Aggregator balance {"balance":"9999998939516696560420"} [2024-10-18 16:44:41.706 -03] INFO (chainio/avs_writer.go:217) Batcher balance {"balance":"1001070133935012705"} [2024-10-18 16:44:43.710 -03] INFO (chainio/avs_writer.go:108) Sending ResponseToTask transaction for 2th with a gas price of 1320000018 [2024-10-18 16:44:43.710 -03] INFO (chainio/avs_writer.go:149) Simulated cost {"cost":"48687100663915"} [2024-10-18 16:44:43.712 -03] INFO (chainio/avs_writer.go:167) Batch RespondToTaskFeeLimit {"RespondToTaskFeeLimit":"1500000010500000"} [2024-10-18 16:44:43.712 -03] INFO (chainio/avs_writer.go:199) Aggregator balance {"balance":"9999998939516696560420"} [2024-10-18 16:44:43.713 -03] INFO (chainio/avs_writer.go:217) Batcher balance {"balance":"1001070133935012705"} [2024-10-18 16:44:45.722 -03] INFO (chainio/avs_writer.go:108) Sending ResponseToTask transaction for 3th with a gas price of 1716000023 [2024-10-18 16:44:45.722 -03] INFO (chainio/avs_writer.go:149) Simulated cost {"cost":"58424520796698"} [2024-10-18 16:44:45.724 -03] INFO (chainio/avs_writer.go:167) Batch RespondToTaskFeeLimit {"RespondToTaskFeeLimit":"1500000010500000"} [2024-10-18 16:44:45.725 -03] INFO (chainio/avs_writer.go:199) Aggregator balance {"balance":"9999998939516696560420"} [2024-10-18 16:44:45.725 -03] INFO (chainio/avs_writer.go:217) Batcher balance {"balance":"1001070133935012705"} [2024-10-18 16:44:47.734 -03] INFO (chainio/avs_writer.go:108) Sending ResponseToTask transaction for 4th with a gas price of 2402400032 [2024-10-18 16:44:47.734 -03] INFO (chainio/avs_writer.go:149) Simulated cost {"cost":"75951877018003"} [2024-10-18 16:44:47.736 -03] INFO (chainio/avs_writer.go:167) Batch RespondToTaskFeeLimit {"RespondToTaskFeeLimit":"1500000010500000"} [2024-10-18 16:44:47.736 -03] INFO (chainio/avs_writer.go:199) Aggregator balance {"balance":"9999998939516696560420"} [2024-10-18 16:44:47.737 -03] INFO (chainio/avs_writer.go:217) Batcher balance {"balance":"1001070133935012705"} [2024-10-18 16:44:48.836 -03] INFO (pkg/aggregator.go:313) - Unlocked Wallet Resources: Sending aggregated response for batch 4a99727c126f5de1585ae54b493f046d3c0bfdb56fb4a59711427b0f1dd098c1 [2024-10-18 16:44:48.837 -03] INFO (pkg/aggregator.go:275) Aggregator successfully responded to task {"batchIdentifierHash":"0x4a99727c126f5de1585ae54b493f046d3c0bfdb56fb4a59711427b0f1dd098c1","taskIndex":0}Note: you might get
NonceToLow, that is a matter of timing, since the timer for waiting for a receipt is changed to be 1 second, maybe a transaction gets accepted and when sending again, it can't replace it since it has been accepted. To lower the probability of that, block time was modified to15s.Finally, you should also be able to see the metrics in the aggregator section:
Type of change
Checklist