Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add watchdog for batcher #1311

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

JuArce
Copy link
Collaborator

@JuArce JuArce commented Oct 23, 2024

Batcher Watchdog

Description

This PR adds a watchdog that restart the batcher if it gets stuck trying to send a transaction to ethereum

@JuArce JuArce self-assigned this Oct 23, 2024
@@ -0,0 +1,36 @@
# Batcher Watchdog

The Batcher Watchdog checks a prometheus metric and restart the batcher as needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more detail would be appreciated. Which metric is checked? How often is it checked? What does "as needed" mean? I know the answers because we sit close to each other, but someone in the future will not know this.

@Oppen
Copy link
Collaborator

Oppen commented Oct 23, 2024

Seems OK overall.

@JuArce JuArce linked an issue Oct 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@IAvecilla IAvecilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JuArce JuArce merged commit 9100ad0 into staging Nov 4, 2024
1 check passed
@JuArce JuArce deleted the 1310-infra-add-watchdog-for-batcher branch November 4, 2024 13:58
PatStiles pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infra: add watchdog for Batcher
3 participants