Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): GetNotRespondedTasksFrom Retries #1432

Open
wants to merge 20 commits into
base: staging
Choose a base branch
from

Conversation

PatStiles
Copy link
Contributor

Add Retry Logic to GetNotRespondedTasksFrom

Description

#closes 1415

How to test

In devnet

  1. make anvil_start_with_block_time
  2. make aggregator_start
  3. make operator_full_registration CONFIG_FILE=config-files/config-operator-1.yaml
  4. make operator_start CONFIG_FILE=config-files/config-operator-1.yaml
  5. make batcher_start_local
  6. make telemetry_full_start

Once you have the system running, send proofs

  1. make batcher_send_burst_groth16
  2. Go to jaeger http://localhost:16686/search
  3. You should see the traces correctly created and task verified
image

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • [https://github.com/feat(operator): Operator Retries #1415] Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles changed the title add retry logic to GetNotRespondedTasksFrom feat(operator): GetNotRespondedTasksFrom Retries Nov 16, 2024
@PatStiles PatStiles marked this pull request as draft November 16, 2024 05:26
@PatStiles PatStiles marked this pull request as ready for review November 19, 2024 10:40
@PatStiles PatStiles changed the base branch from 1401-1414-aggregator-retry-improvements to staging November 19, 2024 17:27
@PatStiles PatStiles force-pushed the 1415-get-not-responded-tasks-from branch from eac4750 to 92f6375 Compare November 19, 2024 19:03
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the retry function and it is working fine. Btw, it seems you have started from this pr #1425 and most of the diff belongs to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants