Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pause process with multisig #1482

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

JuArce
Copy link
Collaborator

@JuArce JuArce commented Nov 23, 2024

Pause process with multisig wallet

Description

This PR adds docs for the pause process using a multisig for the AlignedLayerServiceManager or the BatcherPaymentService

Type of change

  • Documentation

@JuArce JuArce self-assigned this Nov 23, 2024
@JuArce JuArce marked this pull request as ready for review November 25, 2024 19:02
@PatStiles
Copy link
Contributor

We should add a section on verifying via cast or another tool that the contract is paused.

Comment on lines +60 to +62
```
make get_paused_state_batcher_payments_service
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the following error when running this:

/bin/bash: contracts/scripts/get_paused_state_batcher_payments_service.sh: No such file or directory

Copy link
Contributor

@uri-99 uri-99 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, working on the fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed on #1501

docs/0_internal/4_a_pause_contracts.md Show resolved Hide resolved
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req changes until i do some fixes


2. Go to the `Transactions` tab and find the transaction that was proposed.

3. Get the ```pauseAll()``` signature by running:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Get the ```pauseAll()``` signature by running:
3. Get the ```pauseAll()``` signature by running in your terminal:


To propose the pause transaction you can follow the steps below:

1. Go to [Safe](https://app.safe.global/home)
Copy link
Collaborator

@avilagaston9 avilagaston9 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Go to [Safe](https://app.safe.global/home)
1. Go to [Safe](https://app.safe.global/home) and connect your wallet.

Copy link
Collaborator

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my machine. Left some minor comments

Copy link

github-actions bot commented Nov 27, 2024

Changes to gas cost

Generated at commit: 1c4485c3cf8593615318faa2543da4b3e9b1442d, compared to commit: d57c02803650e34b3e053e136339438549e5d354

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask +161 ❌ +0.21%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 5,231,234 (0) createNewTask
receive
56,047 (-72)
23,317 (0)
-0.13%
0.00%
75,959 (+161)
46,821 (+186)
+0.21%
+0.40%
76,199 (+48)
47,195 (0)
+0.06%
0.00%
77,069 (-12)
47,195 (0)
-0.02%
0.00%
256 (0)
256 (0)
RegistryCoordinatorHarness 5,862,162 (+125,839)

Comment on lines +45 to +47
1. Propose the transaction with the multisig following the [Propose Unpause Guide](./4_b_3_propose_unpause.md).

2. After the unpause is proposed, multisig participants can approve the unpause following the [Approve Unpause Guide](./4_b_4_approve_unpause.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links are added in this pr

@uri-99 uri-99 enabled auto-merge November 27, 2024 18:19
@uri-99 uri-99 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into staging with commit e5b753a Nov 27, 2024
3 checks passed
@uri-99 uri-99 deleted the 1422-docs-add-pause-process-with-multisig branch November 27, 2024 18:54
avilagaston9 pushed a commit that referenced this pull request Nov 29, 2024
Co-authored-by: Klaus @ LambdaClass <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]>
Co-authored-by: Urix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants