Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(docs): add docs for unpause process with multisig #1497

Merged
merged 20 commits into from
Dec 9, 2024
Merged

Feat(docs): add docs for unpause process with multisig #1497

merged 20 commits into from
Dec 9, 2024

Conversation

PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Nov 27, 2024 •
edited
Loading

Add docs for unpause process with multisig

Description

Closes #1486

  • Add docs for unpause process with multisig
  • Fix an environment variable sourcing issue in deploy_batcher_payment_service

Type of change

Please delete options that are not relevant.

  • New feature

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Changes to gas cost

Generated at commit: 75a367e52dd427c85422ad7b12c9b9af565a0838, compared to commit: d57c02803650e34b3e053e136339438549e5d354

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask
receive		 +477 ❌
+560 ❌		 +0.63%
+1.20%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 5,231,234 (0) createNewTask
receive		 75,983 (+19,864)
47,195 (+23,878)		 +35.40%
+102.41%		 76,275 (+477)
47,195 (+560)		 +0.63%
+1.20%		 76,211 (+60)
47,195 (0)		 +0.08%
0.00%		 76,994 (-87)
47,195 (0)		 -0.11%
0.00%		 256 (0)
256 (0)
RegistryCoordinatorHarness 5,862,162 (+125,839)

@uri-99 uri-99 changed the base branch from staging to 1422-docs-add-pause-process-with-multisig November 27, 2024 18:12
avilagaston9
avilagaston9 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nit comments. Otherwise, LGTM

docs/0_internal/4_b_3_propose_unpause.md Outdated Show resolved Hide resolved
docs/0_internal/4_b_3_propose_unpause.md Show resolved Hide resolved
docs/0_internal/4_b_4_approve_unpause.md Outdated Show resolved Hide resolved
Base automatically changed from 1422-docs-add-pause-process-with-multisig to staging November 27, 2024 18:54
@uri-99 uri-99 added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@JuArce JuArce enabled auto-merge December 6, 2024 15:24
@JuArce JuArce added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2024
@JuArce JuArce added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@JuArce JuArce added this pull request to the merge queue Dec 9, 2024
Merged via the queue into staging with commit eadd8ae Dec 9, 2024
1 check passed
@JuArce JuArce deleted the 1486-add-unpause-process-with-multisig branch December 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

@avilagaston9 avilagaston9 avilagaston9 approved these changes

@JuArce JuArce JuArce approved these changes

@uri-99 uri-99 uri-99 approved these changes

Assignees

@PatStiles PatStiles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PatStiles @uri-99 @JuArce @avilagaston9 @MarcosNicolau @klaus993