Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aggregator quorum reached and task responded latency gauges #1565

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

JulianVentura
Copy link
Collaborator

@JulianVentura JulianVentura commented Dec 4, 2024

Add latency gauges to aggregator

Description

This PR adds quorum reached and task responded latency gauges to the grafana dashboard.

How to test

  1. Start all services locally, including the metrics
  2. Start sending proofs
  3. Go to the end of "System Data" dashboard, you should see two new panels showing latencies for both quorum reached and task responded.

Note: If you run with anvil, these latencies will show always the same. For a more real scenario, you should try with ethereum package.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JulianVentura JulianVentura marked this pull request as ready for review December 5, 2024 13:37
@PatStiles
Copy link
Contributor

Ran locally and metrics were displayed

Copy link
Collaborator

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uri-99 uri-99 added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@uri-99 uri-99 added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2024
@JuArce JuArce added this pull request to the merge queue Dec 10, 2024
Merged via the queue into staging with commit a4e8e31 Dec 10, 2024
3 checks passed
@JuArce JuArce deleted the feat/latency-measurements-aggregator branch December 10, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants