Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: deprecated verifyBatchInclusion function #1575

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 4, 2024

Caution

This PR modifies contracts, they should be upgraded before merge

Warning

This PR modifies contracts, they should be upgraded before merge

Remove deprecated verifyBatchInclusion

Description

This PR removes the deprecated verifyBatchInclusion function from the AlignedLayerServiceManager.sol

For this change, the AlignedLayerServiceManager contracts must be redeployed.

To Test

  • Test everything is running smoothly
  • Deploy the old version of the contract in holesky, then run the upgrade. In the new version you will see only 1 verifyBatchInclusion function/

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor
  • Remove

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Copy link

github-actions bot commented Dec 4, 2024

Changes to gas cost

Generated at commit: a67f7b90b01fc8879602656e266f78aa87ef7fe9, compared to commit: f0d911543f7339cee83f8bee32d16a6a4a3d4b79

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager batchesState +22 ❌ +3.05%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 5,136,699 (-94,535) batchesState
createNewTask
disabledVerifiers
receive
setDisabledVerifiers
744 (+22)
55,997 (-62)
405 (+22)
23,317 (0)
23,821 (+22)
+3.05%
-0.11%
+5.74%
0.00%
+0.09%
744 (+22)
75,962 (+50)
405 (+22)
46,915 (+187)
34,828 (+22)
+3.05%
+0.07%
+5.74%
+0.40%
+0.06%
744 (+22)
76,125 (-92)
405 (+22)
47,195 (0)
34,828 (+22)
+3.05%
-0.12%
+5.74%
0.00%
+0.06%
744 (+22)
77,019 (+49)
405 (+22)
47,195 (0)
45,835 (+22)
+3.05%
+0.06%
+5.74%
0.00%
+0.05%
256 (0)
256 (0)
1 (0)
256 (0)
2 (0)

@uri-99 uri-99 self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants