Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add aligned-cli readme #1590

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Conversation

PatStiles
Copy link
Contributor

Aligned CLI readme

Description

Adds an readme for the aligned CLI that displays and describes all its flags and parameters. This is intended to be used in alongside the other examples within the documentation for usage.

A separate PR should be done to make the naming conventions throughout the repo consistent. ref: #1589 . It would be recommended to do this in parts as it may introduce breaking changes.

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles self-assigned this Dec 9, 2024
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
docs/3_guides/9_aligned_cli.md Outdated Show resolved Hide resolved
@PatStiles PatStiles changed the title fear(docs): Add aligned-cli readme feat(docs): Add aligned-cli readme Dec 10, 2024
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should wait until the other CLI prs get merged before merging one.

Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing to update the summary.MD

@PatStiles
Copy link
Contributor Author

There is missing to update the summary.MD

Cambio! @JuArce I also added a missing link for Submitting Batch without Batcher

- `submit [OPTIONS] --proving_system <Proving system> --proof <Proof file path>`: Submit a proof or (repetitions of a proof) to the Aligned Layer batcher.

- Options:
- `--batcher_url <Batcher connection address>`: Websocket URL for the Aligned Layer batcher.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the common urls: holesky and mainnet

- **default**: `./aligned_verification_data/`
- `--keystore_path <Path to local keystore>`: Path to the local keystore of the user's wallet.
- `--private_key <Private key>`: User's wallet private key.
- `--max_fee <Max Fee (ether)>`: Amount of Ethereum in Wei to deposit into the `BatcherPaymentService.sol` contract to pay for proof submission.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example

- `--network <The working network's name>`: The Ethereum network of the Aligned Layer Network the user is querying their balance on.
- **default**: `devnet`
- **possible values**: `devnet`, `holesky`, `holesky-stage`, `mainnet`
- `--amount <Amount to deposit>`: Amount of Ethereum in Wei to deposit into the `BatcherPaymentService.sol` contract to pay for proof submission.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an example

- `get-user-nonce [OPTIONS] --user_addr <The user's Ethereum address>`: Retrieves the user's current nonce from the batcher.

- Options:
- `--batcher_url <Batcher connection address>`: Websocket URL for the Aligned Layer batcher.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add possible values


1. Deposit funds to the batcher.
```bash
aligned deposit-to-batcher --network holesky --amount 0.5ether --keystore_path <KEYSTORE_PATH>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deposit to batcher spec is in wei and it is using ether. Check which one is correct


2. Check your balance in the aligned batcher.
```bash
aligned get-user-balance --user_addr <WALLET_ADDRESS> --network holesky
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says holesky, but does not specify the batcher_url


3. Submit a Proof.
```bash
aligned submit --proving_system Risc0 --proof ./scripts/test_files/risc_zero/fibonacci_proof_generator/risc_zero_fibonacci.proof --vm_program ./scripts/test_files/risc_zero/fibonacci_proof_generator/fibonacci_id.bin --public_input ./scripts/test_files/risc_zero/fibonacci_proof_generator/risc_zero_fibonacci.pub --repetitions <BURST_SIZE> --keystore_path <KEYSTORE_PATH> --network holesky --max_fee 1300000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing batcher_url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants