Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Bump sp1 version in validating public inputs example #1634

Merged
merged 6 commits into from
Dec 21, 2024

Conversation

PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Dec 17, 2024

Hotfix: bump sp1 version in validating public inputs example

Description

Fixes the version in the validating public input example.

To Test

  • To test this on the holesky network you will need a holesky eth wallet. For reference follow the example readme here.
  • cd examples/validating-public-input/
  • In examples/validating-public-input/contracts create a .env with the parameters for the holesky testnet.

For Sp1:

  • Generate the sp1 proof: make generate_sp1_fibonacci_proof
  • Send the proof to testnet: make submit_fibonacci_sp1_proof KEYSTORE_PATH=<LOCAL_KEYSTORE_PATH>
  • Deploy the validating contract make deploy_fibonacci_validator KEYSTORE_PATH=<LOCAL_KEYSTORE_PATH>
  • make verify_sp1_batch_inclusion FIBONACCI_VALIDATOR_ADDRESS=<FIBONACCI_VALIDATOR_ADDRESS> DATA_FILE_NAME=<DATA_FILE_NAME>. Where FIBONACCI_VALIDATOR_ADDRESS is the address of the deployed validator contract and DATA_FILE_NAME the name of the file where the aligned verification data was saved (including the extension .json).
  • If successful you should see:
...
root                    <ROOT_HASH>
status                  1 (success)
transactionHash         <TX_HASH>
...

For Risc0:

  • Generate the risc0 proof: make generate_risc0_fibonacci_proof
  • Send the proof to testnet: make submit_fibonacci_risc0_proof KEYSTORE_PATH=<LOCAL_KEYSTORE_PATH>
  • Deploy the validating contract make deploy_fibonacci_validator KEYSTORE_PATH=<LOCAL_KEYSTORE_PATH>
  • make verify_risc0_batch_inclusion FIBONACCI_VALIDATOR_ADDRESS=<FIBONACCI_VALIDATOR_ADDRESS> DATA_FILE_NAME=<DATA_FILE_NAME>. Where FIBONACCI_VALIDATOR_ADDRESS is the address of the deployed validator contract and DATA_FILE_NAME the name of the file where the aligned verification data was saved (including the extension .json).
  • If successful you should see:
...
root                    <ROOT_HASH>
status                  1 (success)
transactionHash         <TX_HASH>
...

Type of change

Please delete options that are not relevant.

  • Hot Fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. We should lower the max_fee or making it a parameter because it is way too high (0.1ether).

@PatStiles
Copy link
Contributor Author

It works. We should lower the max_fee or making it a parameter because it is way too high (0.1ether).

Addressed!

@JuArce JuArce merged commit d4a7b13 into testnet Dec 21, 2024
3 checks passed
@JuArce JuArce deleted the fix/validating-public-input-sp1-version branch December 21, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants