Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add operator responses dashboard #1648

Merged
merged 15 commits into from
Dec 23, 2024
Merged

Conversation

avilagaston9
Copy link
Collaborator

@avilagaston9 avilagaston9 commented Dec 18, 2024

Add Operator Responses Dashboard

Description

This PR adds a new Grafana dashboard with the count of the operators responses received in the selected time range:

image

How to test

You can follow similar steps as #1621 to test the full flow of this PR.

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 self-assigned this Dec 18, 2024
@avilagaston9 avilagaston9 marked this pull request as ready for review December 18, 2024 21:25
Copy link
Contributor

@PatStiles PatStiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything works!

Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! Question: doesn't this metric make the one from #1621 redundant? Since this metric shows the number of responded tasks and the total tasks, the difference in responded tasks can be derived (this could be done via Grafana). Also, this metric updates in real time, whereas the one in #1621 updates only when quorum is reached.

Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Sort the values by lower responding operators first
  • Show a single color without gradient

Base automatically changed from operator-liveness-metric to staging December 23, 2024 16:56
@avilagaston9
Copy link
Collaborator Author

  • Sort the values by lower responding operators first
  • Show a single color without gradient
    @JuArce

Addressed both using a table + override with a gauge display. I had to use the "RETRO LCD" display because with the basic one, the progress bar appears empty when all values are the same:

image image

@JuArce JuArce enabled auto-merge December 23, 2024 20:30
@JuArce JuArce added this pull request to the merge queue Dec 23, 2024
Merged via the queue into staging with commit b0d08c4 Dec 23, 2024
1 check passed
@JuArce JuArce deleted the operator-liveness-metric-2 branch December 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants