Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: periodic updates for batcher page #1666

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

Oppen
Copy link
Collaborator

@Oppen Oppen commented Dec 20, 2024

Motivation

Details like age and badge weren't updating. Fixes #1646.

  • Extract batch age to a field in the dict so LiveView knows when it changed
  • Broadcast an event on the block update task so views know to update assigns

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Testing

  1. Deploy a devnet and the explorer.
  2. Send a few proofs.
  3. Stop sending proofs.
  4. Go to the ex batches page. You should see the age column updating about once a minute.
  5. Kill the operator.
  6. Send a few more proofs.
  7. Stop sending proofs.
  8. After a while (5 minutes by default) the pending proofs should start turning red, with the badge signaling "unverified".
  9. Verify also for a given batch and for the frontpage.

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

* Extract batch age to a field in the dict so LiveView knows when it changed
* Broadcast an event on the block update task so views know to update assigns
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely!

@uri-99 uri-99 merged commit f473f6d into explorer-new-version Dec 23, 2024
1 check passed
@uri-99 uri-99 deleted the fix/explorer_periodic_updates branch December 23, 2024 21:17
@uri-99 uri-99 mentioned this pull request Dec 23, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants