Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: explorer missing vars throw 500 #1676

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 21, 2024

hotfix explorer set all vars when catching a panic

Description

This PR makes the explorer home page to set all corresponding variables to :empty when handling a panic case.
The error was that there were a couple of new variables that were not set in a panic.

This is a hotfix, this same fix should be applied to all explorer pages

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce merged commit 5143bd5 into testnet Dec 21, 2024
1 check passed
@JuArce JuArce deleted the hotfix-explorer-missing-vars-throw-500 branch December 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants