Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: min_batch_size to send 1000 proofs #1689

Open
wants to merge 7 commits into
base: testnet
Choose a base branch
from

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 30, 2024

Feat min_batch_size in batcher

Warning

This PR involves a change in config-batcher.yaml

Description

This PR was made to make possible the submition of single batches of a declared size.

The need arises when we want to send a single batch of 1000 proofs. Without this feature it is very error-prone, which in mainnet means funds spent in an unintended way.

To test

  • Run setup locally
  • send different amount of proofs, verifying only batches of size at least N are built and submitted

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 changed the title Test send 1000 proofs hotfix: min_batch_size to send 1000 proofs Dec 30, 2024
@uri-99 uri-99 marked this pull request as ready for review December 30, 2024 18:32
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Maybe we can add modify the message to something like: Current batch has N proofs. Min is X proofs. Waiting for more proofs....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants