-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix: make aggregator fee multiplier customizable #1690
base: testnet
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked locally LGTM
pub const BATCHER_SUBMISSION_BASE_GAS_COST: u128 = 125_000; | ||
pub const ADDITIONAL_SUBMISSION_GAS_COST_PER_PROOF: u128 = 13_000; | ||
pub const ADDITIONAL_SUBMISSION_GAS_COST_PER_PROOF: u128 = 2_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify this number is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is ok
batcher.aggregator_fee_percentage_multiplier
, usingDEFAULT_AGGREGATOR_FEE_PERCENTAGE_MULTIPLIER
as a default if not set;batcher.aggregator_fee_percentage_multiplier
config.Testing
Basic testing involves just the regular flow, start a devnet, send some proofs, check that they verify and batches make it to L1. The expected behavior is cheaper costs, in the telemetry it should show changes vs testnet in
fee per proof
.To test more in depth, try:
batcher.aggregator_fee_percentage_multiplier
, it should work and charge the same (the defaults in the example config files and the constant match);Each of these changes should require only a batcher restart, not recompilation and not restarting of other components.
Type of change
Checklist
testnet
, everything else tostaging