Add ci #25
Merged
Add ci #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mariano A. Nicolini <[email protected]>
entropidelic
approved these changes
Apr 24, 2024
Comment on lines
+27
to
+55
| # Require: The version of golangci-lint to use. | ||
| # When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version. | ||
| # When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit. | ||
| version: v1.54 | ||
|
|
||
| # Optional: working directory, useful for monorepos | ||
| # working-directory: somedir | ||
|
|
||
| # Optional: golangci-lint command line arguments. | ||
| # | ||
| # Note: By default, the `.golangci.yml` file should be at the root of the repository. | ||
| # The location of the configuration file can be changed by using `--config=` | ||
| # args: --timeout=30m --config=/my/path/.golangci.yml --issues-exit-code=0 | ||
|
|
||
| # Optional: show only new issues if it's a pull request. The default value is `false`. | ||
| # only-new-issues: true | ||
|
|
||
| # Optional: if set to true, then all caching functionality will be completely disabled, | ||
| # takes precedence over all other caching options. | ||
| # skip-cache: true | ||
|
|
||
| # Optional: if set to true, then the action won't cache or restore ~/go/pkg. | ||
| # skip-pkg-cache: true | ||
|
|
||
| # Optional: if set to true, then the action won't cache or restore ~/.cache/go-build. | ||
| # skip-build-cache: true | ||
|
|
||
| # Optional: The mode to install golangci-lint. It can be 'binary' or 'goinstall'. | ||
| # install-mode: "goinstall" |
There was a problem hiding this comment.
are these comments intended to be left just in case?
| with: | ||
| go-version: '1.22' | ||
| cache: false | ||
| - name: Checkout code |
There was a problem hiding this comment.
The first "uses" step checksout, do we need to do it again?
NicolasRampoldi
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI with build and lint