Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add LocalStack for local s3 #647

Merged
merged 16 commits into from
Aug 1, 2024
Merged

chore: add LocalStack for local s3 #647

merged 16 commits into from
Aug 1, 2024

Conversation

JuArce
Copy link
Collaborator

@JuArce JuArce commented Jul 17, 2024 •
edited
Loading

How to test

  1. Run anvil, operator and aggregator
  2. Run docker
  3. Run make batcher_start_local. It will use the .env.dev file with the local bucket credentials. Also, It will run an s3 bucket in a docker container
  4. Send proofs and check everything is working

@JuArce JuArce self-assigned this Jul 17, 2024
@JuArce JuArce linked an issue Jul 17, 2024 that may be closed by this pull request
chore: add s3 for local development #646
Closed
NicolasRampoldi
NicolasRampoldi suggested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@NicolasRampoldi NicolasRampoldi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .env.example is missing the ENVIRONMENT and STORAGE_ENDPOINT variables.

storage-docker-compose.yaml Outdated Show resolved Hide resolved
@JuArce JuArce requested a review from NicolasRampoldi July 18, 2024 23:53
uri-99
uri-99 requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small details, functionality worked

batcher/aligned-batcher/.env.example Outdated Show resolved Hide resolved
batcher/aligned-batcher/.env.local Outdated Show resolved Hide resolved
batcher/aligned-batcher/src/s3/mod.rs Outdated Show resolved Hide resolved
batcher/aligned-batcher/.env.local Outdated Show resolved Hide resolved
uri-99
uri-99 reviewed Jul 19, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@JuArce JuArce requested a review from entropidelic July 20, 2024 01:14
@entropidelic entropidelic merged commit e7a7c41 into main Aug 1, 2024
8 checks passed
@entropidelic entropidelic deleted the 646-chore-add-s3-for-local-development branch August 1, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasRampoldi NicolasRampoldi NicolasRampoldi approved these changes

@uri-99 uri-99 uri-99 approved these changes

@entropidelic entropidelic Awaiting requested review from entropidelic

Assignees

@JuArce JuArce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: add s3 for local development
5 participants
@JuArce @uri-99 @NicolasRampoldi @entropidelic @taturosati