Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (batcher): dont retry + gas escalator + sequential txs #680

Merged
merged 19 commits into from
Jul 30, 2024
Merged

feat (batcher): dont retry + gas escalator + sequential txs #680

merged 19 commits into from
Jul 30, 2024

Conversation

taturosati
Copy link
Contributor

  • Add RetryClient to retry on http errors
  • Use gas escalator to prevent txs stuck on mempool
  • Add lock to write on blockchain to prevent nonce errors (batcher now waits for tx success / failure before sending next tx)

To test

Normal flow

@taturosati taturosati linked an issue Jul 29, 2024 that may be closed by this pull request
feat (batcher): don't retry when not needed #677
Closed
@taturosati taturosati marked this pull request as ready for review July 29, 2024 21:06
entropidelic
entropidelic previously approved these changes Jul 30, 2024
View reviewed changes
@entropidelic entropidelic dismissed their stale review July 30, 2024 18:17

needs further testing

@taturosati taturosati merged commit 1318774 into main Jul 30, 2024
9 checks passed
@taturosati taturosati deleted the 677-feat-batcher-dont-retry-when-not-needed branch July 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasRampoldi NicolasRampoldi NicolasRampoldi approved these changes

@MauroToscano MauroToscano MauroToscano approved these changes

@entropidelic entropidelic entropidelic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat (batcher): don't retry when not needed
4 participants
@taturosati @MauroToscano @NicolasRampoldi @entropidelic