Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont upload nonce to bucket #699

Merged
merged 4 commits into from
Aug 1, 2024
Merged

fix: dont upload nonce to bucket #699

merged 4 commits into from
Aug 1, 2024

Conversation

taturosati
Copy link
Contributor

Revert change. Bucket now holds VerificationData[] instead of NoncedVerificationData[]

To test

Test normal flow, try different proof types

@taturosati taturosati linked an issue Aug 1, 2024 that may be closed by this pull request
fix: don't upload nonce to storage #698
Closed
@taturosati taturosati marked this pull request as ready for review August 1, 2024 13:58
@taturosati taturosati self-assigned this Aug 1, 2024
uri-99
uri-99 requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes the s3 object structure, so a change in how the explorer reads this object is missing

@entropidelic entropidelic merged commit f8ed41a into main Aug 1, 2024
8 checks passed
@entropidelic entropidelic deleted the 698-fix-dont-upload-nonce-to-storage branch August 1, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-99 uri-99 uri-99 approved these changes

@MauroToscano MauroToscano MauroToscano approved these changes

Assignees

@taturosati taturosati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: don't upload nonce to storage
4 participants
@taturosati @MauroToscano @uri-99 @entropidelic